-
Notifications
You must be signed in to change notification settings - Fork 8
Deploy scripts #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deploy scripts #185
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
327937c
fix: deploy scripts
ameeshaagrawal 31fb72e
fix: sb id as input in batcher
ameeshaagrawal 52943d1
fix: scripts
ameeshaagrawal 64da901
feat: dev deployments
ameeshaagrawal fc69064
chore: update readme and fix lint
ameeshaagrawal 4bae8b3
chore: verify contracts
ameeshaagrawal 143682b
fix: deploy-scripts
tHeMaskedMan981 b6c5baa
Merge branch 'deploy-scripts' of https://github.com/SocketDotTech/soc…
tHeMaskedMan981 f7e53f7
Merge branch 'dev' into deploy-scripts
ameeshaagrawal ce204b6
fix: lint
ameeshaagrawal 9bdbc2e
fix: write precompile data
ameeshaagrawal fc2a9d7
chore: uncomment
ameeshaagrawal 64a5446
fix: scripts
tHeMaskedMan981 8cecee0
Merge branch 'deploy-scripts' of https://github.com/SocketDotTech/soc…
tHeMaskedMan981 01f331b
fix: scripts
ameeshaagrawal 3b799bf
feat: stage deployments
ameeshaagrawal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Duplicate error codes across switchboards
AlreadyAttested()
(0x35d90805
) andWatcherNotFound()
(0xa278e4ad
) now appear in both FastSwitchboard and MessageSwitchboard tables.Unless the underlying libraries purposely define separate copies, consider documenting them once (e.g. under a shared “switchboard-common” section) to avoid reader confusion and future drift.
🧰 Tools
🪛 LanguageTool
[grammar] ~96-~96: Use correct spacing
Context: ...WatcherNotFound()
|
0xa278e4ad` | ## protocol/switchboard/MessageSwitchboard.sol | Error | Signat...(QB_NEW_EN_OTHER_ERROR_IDS_5)
🤖 Prompt for AI Agents