Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update post model/controller to respond to limit param #25

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Update post model/controller to respond to limit param #25

merged 1 commit into from
Oct 19, 2017

Conversation

joshmorel
Copy link
Contributor

  • limit default applied in model only
  • added date to PostSchema - should not affect loading from Wordpress
  • updated post.test.js to test limit and changeOnAfter offset
  • added saveMongoArrayPromise utility function to save array of mongo instances prior to running tests, could later be moved to separate util.js file for use by multiple tests

@joshmorel joshmorel changed the title post responds to limit param Update post model/controller to responds to limit param Oct 14, 2017
@joshmorel joshmorel changed the title Update post model/controller to responds to limit param Update post model/controller to respond to limit param Oct 14, 2017
@TheHollidayInn
Copy link
Contributor

Looks great 👍 I’ll test locally then merge

@TheHollidayInn TheHollidayInn merged commit f182a5f into SoftwareEngineeringDaily:master Oct 19, 2017
@TheHollidayInn TheHollidayInn mentioned this pull request Oct 19, 2017
Closed
@joshmorel joshmorel deleted the post-limit-fix branch October 31, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmorel @TheHollidayInn