Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define consumer thread names #268

Closed
AndreKoepke opened this issue Feb 29, 2024 · 0 comments · Fixed by #269
Closed

Define consumer thread names #268

AndreKoepke opened this issue Feb 29, 2024 · 0 comments · Fixed by #269
Labels
enhancement New feature or request

Comments

@AndreKoepke
Copy link
Contributor

What I want?

Clear thread-names would be great.

Why I want it?

We have a lot consumers and got issues because of (unexpected) long-running consumer. I want to check the threads and have the problem thatI cant match the thread to our different consumers.
image

Where can Solace fix it?

How can it be fixed?

  1. Easy -> Create a ThreadFactory with a prefix of the binding. I will create a small PR for it.
  2. Take a ThreadPoolExcutor from application-context. In other words: Allow to give a bean-name in parameters and use that bean.
AndreKoepke added a commit to AndreKoepke/solace-spring-cloud that referenced this issue Feb 29, 2024
@Nephery Nephery linked a pull request May 27, 2024 that will close this issue
@Nephery Nephery added the enhancement New feature or request label May 27, 2024
@Nephery Nephery changed the title Improve thread names Define consumer thread names May 27, 2024
Nephery pushed a commit that referenced this issue Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants