Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Cypress to run tests against the entire SolidOS stack, as suggested in https://github.com/solid/solid-ui/issues/436.
This repository is probably not the best place to add this, because the changes that would break these tests will be made in other repositories. And that's where this should be configured, that way we'll be able to notice if something is broken in each commit instead of waiting for new features to be merged in.
However, I'm not sure how to run the entire stack in other repositories, which is required in order to write Cypress tests because they run on a browser using the real application. Maybe we could publish the scripts in this repository to an npm package and use that to run the entire stack from other repositories. But I'm not sure if that's the best way either, so let's talk about it.
In any case, this should be a first step towards using Cypress in SolidOS :).
Regarding the tests, I've just added a couple to see that things work as expected. Registration works fine, but for some reason loging in doesn't redirect properly and the test is stuck on the login page. If you want to try it, remove the
.skip
part from the test in theauth.spec.js
file.If you want to try running Cypress locally, remember to run
npm install
in order to get the new dependencies, and you can launch Cypress with thenpm run cy:open
command (this one, in contrast withcy:test
, does not launch the app so you should be runningnpm start
as well).If you want to see how this looks like once integrated, check out my fork.