Skip to content

Fixed issue where Half wasn't buildable from the command line #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Fixed issue where Half wasn't buildable from the command line #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58fbdfa
Fixed issue where Half wasn't buildable from the command line
Feb 21, 2020
af60a4e
Added code coverage configuration file to explicitly ignore the code …
Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
Half.xcodeproj/project.xcworkspace
Half.xcodeproj/xcuserdata
.swiftpm
.build
2 changes: 2 additions & 0 deletions Half.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
/* End PBXContainerItemProxy section */

/* Begin PBXFileReference section */
DD6F08D124008A7400749359 /* codecov.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = codecov.yml; sourceTree = "<group>"; };
DDFEEC3323EF13900096015C /* Half.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Half.framework; sourceTree = BUILT_PRODUCTS_DIR; };
DDFEEC3723EF13900096015C /* Half-Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; name = "Half-Info.plist"; path = "Info/Half-Info.plist"; sourceTree = "<group>"; };
DDFEEC3C23EF13910096015C /* HalfTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = HalfTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
Expand Down Expand Up @@ -235,6 +236,7 @@
children = (
DDFEECAB23F1BA550096015C /* Half.podspec */,
DDFEECAC23F1BA550096015C /* Package.swift */,
DD6F08D124008A7400749359 /* codecov.yml */,
DDFEECAE23F1BA5E0096015C /* .swiftlint.yml */,
DDFEECAD23F1BA5E0096015C /* .travis.yml */,
DDFEECAF23F1BA680096015C /* README.md */,
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ let package = Package(
.testTarget(name: "HalfTests", dependencies: ["Half"])
],

swiftLanguageVersions: [.version("4.0"), .version("4.2"), .version("5.0")]
swiftLanguageVersions: [.version("4"), .version("4.2"), .version("5")]
)
22 changes: 11 additions & 11 deletions Tests/HalfTests/Half+CodingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class HalfCodingTests: XCTestCase {

XCTAssertNoThrow(data = try JSONEncoder().encode(simple))
XCTAssertNoThrow(decoded = try JSONDecoder().decode(Simple.self, from: data))
try XCTAssertEqual(XCTUnwrap(decoded), simple)
XCTAssertEqual(decoded, simple)
}
do {
let values: [Half] = [1.0, 2.0, 3.0]
Expand All @@ -40,7 +40,7 @@ class HalfCodingTests: XCTestCase {

XCTAssertNoThrow(data = try JSONEncoder().encode(values))
XCTAssertNoThrow(decoded = try JSONDecoder().decode([Half].self, from: data))
try XCTAssertEqual(XCTUnwrap(decoded), values)
XCTAssertEqual(decoded, values)
}
do {
let values: [Simple] = [Simple(half: 1.5, int: 1), Simple(half: 2.5, int: 2), Simple(half: 3.5, int: 3)]
Expand All @@ -49,7 +49,7 @@ class HalfCodingTests: XCTestCase {

XCTAssertNoThrow(data = try JSONEncoder().encode(values))
XCTAssertNoThrow(decoded = try JSONDecoder().decode([Simple].self, from: data))
try XCTAssertEqual(XCTUnwrap(decoded), values)
XCTAssertEqual(decoded, values)
}
do {
let simple = Simple(half: .infinity, int: 0)
Expand All @@ -65,8 +65,8 @@ class HalfCodingTests: XCTestCase {
XCTAssertNoThrow(data = try encoder.encode(simple))
XCTAssertNoThrow(decoded = try decoder.decode(Simple.self, from: data))

try XCTAssertEqual(XCTUnwrap(decoded).int, simple.int)
try XCTAssertTrue(XCTUnwrap(decoded).half.isInfinite)
XCTAssertEqual(decoded.int, simple.int)
XCTAssertTrue(decoded.half.isInfinite)
}
do {
let simple = Simple(half: -.infinity, int: 0)
Expand All @@ -82,8 +82,8 @@ class HalfCodingTests: XCTestCase {
XCTAssertNoThrow(data = try encoder.encode(simple))
XCTAssertNoThrow(decoded = try decoder.decode(Simple.self, from: data))

try XCTAssertEqual(XCTUnwrap(decoded).int, simple.int)
try XCTAssertTrue(XCTUnwrap(decoded).half.isInfinite)
XCTAssertEqual(decoded.int, simple.int)
XCTAssertTrue(decoded.half.isInfinite)
}
do {
let simple = Simple(half: .nan, int: 0)
Expand All @@ -99,8 +99,8 @@ class HalfCodingTests: XCTestCase {
XCTAssertNoThrow(data = try encoder.encode(simple))
XCTAssertNoThrow(decoded = try decoder.decode(Simple.self, from: data))

try XCTAssertEqual(XCTUnwrap(decoded).int, simple.int)
try XCTAssertTrue(XCTUnwrap(decoded).half.isNaN)
XCTAssertEqual(decoded.int, simple.int)
XCTAssertTrue(decoded.half.isNaN)
}
do {
let simple = Simple(half: .signalingNaN, int: 0)
Expand All @@ -116,8 +116,8 @@ class HalfCodingTests: XCTestCase {
XCTAssertNoThrow(data = try encoder.encode(simple))
XCTAssertNoThrow(decoded = try decoder.decode(Simple.self, from: data))

try XCTAssertEqual(XCTUnwrap(decoded).int, simple.int)
try XCTAssertTrue(XCTUnwrap(decoded).half.isNaN)
XCTAssertEqual(decoded.int, simple.int)
XCTAssertTrue(decoded.half.isNaN)
}
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/HalfTests/HalfTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ class HalfTests: XCTestCase {
XCTAssertEqual(Half(uint), 1.0)
XCTAssertEqual(Half(uint), 1)

try XCTAssertEqual(XCTUnwrap(Half(exactly: 8)), 8.0)
XCTAssertEqual(Half(exactly: 8), 8.0)
XCTAssertNil(Half(exactly: Int64.max))
}

Expand Down
23 changes: 23 additions & 0 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
codecov:
require_ci_to_pass: yes

coverage:
precision: 2
round: down
range: "70...100"

parsers:
gcov:
branch_detection:
conditional: yes
loop: yes
method: no
macro: no

comment:
layout: "reach,diff,flags,tree"
behavior: default
require_changes: no

ignore:
- Tests/**/*