Fix unescaped regexp chars and remove SQ exclusion (#4257)

SonarSource · Oct 9, 2023 · 0bd6d4e · 0bd6d4e
1 parent 7cd8026
commit 0bd6d4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/jsts/tests/tools/testers/comment-based/helpers/quickfixes.ts b/packages/jsts/tests/tools/testers/comment-based/helpers/quickfixes.ts
@@ -31,7 +31,7 @@ const QUICKFIX_DESCRIPTION_PATTERN = RegExp(
     'fix@(?<quickfixId>\\w+)' +
     // message, ex: {{msg}}
     ' *(?:\\{\\{(?<message>.*?)\\}\\}(?!\\}))? *' +
-    '(?:\r(\n?)|\n)?',
+    '(?:\\r(\\n?)|\\n)?',
 );
 
 const QUICKFIX_CHANGE_PATTERN = RegExp(
@@ -45,7 +45,7 @@ const QUICKFIX_CHANGE_PATTERN = RegExp(
     '\\]\\])?' +
     // contents to be applied, ex: {{foo}}
     ' *(?:\\{\\{(?<contents>.*?)\\}\\}(?!\\}))?' +
-    ' *(?:\r(\n?)|\n)?',
+    ' *(?:\\r(\\n?)|\\n)?',
 );
 
 type ChangeType = 'add' | 'del' | 'edit';

diff --git a/pom.xml b/pom.xml
@@ -80,7 +80,7 @@
 
     <!-- sonar analysis -->
     <sonar.sources>packages/</sonar.sources>
-    <sonar.exclusions>packages/**/*.test.ts,packages/**/*.fixture.*,packages/**/fixtures/**/*,packages/jsts/tests/tools/testers/comment-based/helpers/quickfixes.ts</sonar.exclusions>
+    <sonar.exclusions>packages/**/*.test.ts,packages/**/*.fixture.*,packages/**/fixtures/**/*</sonar.exclusions>
     <sonar.tests>packages/</sonar.tests>
     <sonar.test.inclusions>packages/**/*.test.ts</sonar.test.inclusions>
     <sonar.javascript.lcov.reportPaths>coverage/lcov.info</sonar.javascript.lcov.reportPaths>