Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint-based rules with parameters #1082

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Add eslint-based rules with parameters #1082

merged 3 commits into from
Oct 2, 2018

Conversation

vilchik-elena
Copy link
Contributor

Fixes #945, Fixes #943

@ghost ghost assigned vilchik-elena Sep 28, 2018
@ghost ghost added the in progress label Sep 28, 2018
@vilchik-elena vilchik-elena changed the base branch from master to add-new-rules October 1, 2018 12:34
@vilchik-elena vilchik-elena changed the title WIP Add rules with parameters Add eslint-based rules with parameters Oct 1, 2018
sonarsource-next[bot]
sonarsource-next bot reviewed Oct 1, 2018
View reviewed changes
Copy link

@sonarsource-next sonarsource-next bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarQube

andrea-guarino-sonarsource
andrea-guarino-sonarsource approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrea-guarino-sonarsource andrea-guarino-sonarsource changed the base branch from add-new-rules to master October 1, 2018 16:13
@andrea-guarino-sonarsource andrea-guarino-sonarsource merged commit 5cff030 into master Oct 2, 2018
@ghost ghost removed the in progress label Oct 2, 2018
@andrea-guarino-sonarsource andrea-guarino-sonarsource deleted the parameter-rules branch October 2, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonarsource-next sonarsource-next[bot] sonarsource-next[bot] left review comments

@andrea-guarino-sonarsource andrea-guarino-sonarsource andrea-guarino-sonarsource approved these changes

Assignees

@vilchik-elena vilchik-elena

@andrea-guarino-sonarsource andrea-guarino-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vilchik-elena @andrea-guarino-sonarsource