Update "submit review" and "request review" actions to work for projectsV2 #4012
Conversation
github-actions
bot
assigned ilia-kebets-sonarsource and victor-diez-sonarsource and unassigned ilia-kebets-sonarsource
github-actions
bot
assigned ilia-kebets-sonarsource and victor-diez-sonarsource and unassigned victor-diez-sonarsource and ilia-kebets-sonarsource
github-actions
bot
assigned yassin-kammoun-sonarsource and unassigned victor-diez-sonarsource
ilia-kebets-sonarsource
requested review from
yassin-kammoun-sonarsource
and removed request for
yassin-kammoun-sonarsource
ilia-kebets-sonarsource
requested review from
yassin-kammoun-sonarsource
and removed request for
yassin-kammoun-sonarsource
|
SonarQube Quality Gate
|
ilia-kebets-sonarsource
requested review from
yassin-kammoun-sonarsource
and removed request for
yassin-kammoun-sonarsource
|
SonarQube Quality Gate
|
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| if: | | ||
| github.event.pull_request.head.repo.full_name == github.repository | ||
| && github.event.review.author_association != 'NONE' |
There was a problem hiding this comment.
What's the meaning of this extra condition ? What's an author association ?
There was a problem hiding this comment.
I'll explain tomorrow.
There was a problem hiding this comment.
it means that the reviewer has at least some rights on the repo: https://docs.github.com/en/webhooks-and-events/events/issue-event-types#properties-for-commented
There was a problem hiding this comment.
Do you plan to document this kind of detail somewhere?
There was a problem hiding this comment.
These actions are made to be copy-pasted from their templates, and a few parameters replaced like this one from here: https://github.com/SonarSource/gh-action-lt-backlog/tree/master/MoveCardAfterReview#projects-v2
So we don't deem the documentation necessary.
hashicorp-vault-sonar-prod
bot
assigned ilia-kebets-sonarsource and unassigned yassin-kammoun-sonarsource
When merged, we would need to change the branches to @v1 like:
instead of