Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ucfg rule for JS embedded in HTML files #4074

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

ilia-kebets-sonarsource
Copy link
Contributor

Fixes #4036

@sonarqube-next
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need an integration test for this change.

@ilia-kebets-sonarsource
Copy link
Contributor Author

Dropping this, because we haven't found the source of the issue that was initially raised in community.

@ilia-kebets-sonarsource ilia-kebets-sonarsource deleted the issue-3389-disable-ucfg-for-html branch August 23, 2023 08:41
@vdiez vdiez restored the issue-3389-disable-ucfg-for-html branch March 26, 2024 09:32
@vdiez vdiez reopened this Mar 26, 2024
@vdiez vdiez force-pushed the issue-3389-disable-ucfg-for-html branch from 4d5ca1d to 2f9faf6 Compare March 26, 2024 09:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job writing those integration tests.
I left some suggestions about a few assertions.
Looks good to me otherwise!

@vdiez vdiez enabled auto-merge (squash) March 27, 2024 11:17
@vdiez vdiez merged commit ce1d001 into master Mar 27, 2024
14 checks passed
@vdiez vdiez deleted the issue-3389-disable-ucfg-for-html branch March 27, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not generate UCFGs for JavaScript code inside HTML
4 participants