-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ucfg rule for JS embedded in HTML files #4074
Conversation
SonarQube Quality Gate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need an integration test for this change.
Dropping this, because we haven't found the source of the issue that was initially raised in community. |
4d5ca1d
to
2f9faf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job writing those integration tests.
I left some suggestions about a few assertions.
Looks good to me otherwise!
its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/HtmlSecurityTest.java
Outdated
Show resolved
Hide resolved
its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/HtmlSecurityTest.java
Outdated
Show resolved
Hide resolved
its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/YamlSecurityTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Fixes #4036