S5773: VB.NET implementation #7623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S5773-vbnet-implementation
branch
from
3949322 to
65ce403
Compare
zsolt-kolbay-sonarsource
changed the title
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S5773-vbnet-implementation
branch
from
65ce403 to
1d541aa
Compare
Tim-Pohlmann
force-pushed
the
Tim/S5773_Implementation
branch
from
9482796 to
190a3a7
Compare
Closed
5 tasks
mary-georgiou-sonarsource
force-pushed
the
Zsolt/S5773-vbnet-implementation
branch
4 times, most recently
from
4f19999 to
6cc406f
Compare
Tim-Pohlmann
force-pushed
the
Zsolt/S5773-vbnet-implementation
branch
from
6cc406f to
4344119
Compare
Tim-Pohlmann
assigned zsolt-kolbay-sonarsource and unassigned Tim-Pohlmann and zsolt-kolbay-sonarsource
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/S5773-vbnet-implementation
branch
from
75a21c5 to
2e10b80
Compare
| @@ -35,6 +35,28 @@ public override bool ShouldExecute() | |||
| return walker.Result; | |||
| } | |||
|
|
|||
| protected override SyntaxNode BindToTypeDeclaration(IOperation operation) => | |||
There was a problem hiding this comment.
I find this name confusing - because of the verb Bind it sounds like it Binds something, when my understanding is that it tries to find the declaration of a particular method. Is that correct?
Tim-Pohlmann
requested changes
Jul 24, 2023
Comment on lines
+3
to
+15
| { | ||
| "id": "S5773", | ||
| "message": "Restrict types of objects allowed to be deserialized.", | ||
| "location": { | ||
| "uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/sources/Ember-MM/Addons/scraper.EmberCore/TVScraper/clsScrapeTVDB.vb#L150", | ||
| "region": { | ||
| "startLine": 150, | ||
| "startColumn": 41, | ||
| "endLine": 150, | ||
| "endColumn": 59 | ||
| } | ||
| } | ||
| } |
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/RestrictDeserializedTypes.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/RestrictDeserializedTypes.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.CSharp/SymbolicExecution/Roslyn/RestrictDeserializedTypes.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.VisualBasic/SymbolicExecution/Roslyn/RestrictDeserializedTypes.cs
Outdated
Show resolved
Hide resolved
...alyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/RestrictDeserializedTypes.LosFormatter.vb
Outdated
Show resolved
Hide resolved
Tim-Pohlmann
approved these changes
Jul 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
mary-georgiou-sonarsource
added a commit
that referenced
this pull request
Jul 25, 2023
Co-authored-by: mary-georgiou-sonarsource <mary.georgiou@sonarsource.com> Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>
mary-georgiou-sonarsource
added a commit
that referenced
this pull request
Jul 26, 2023
Co-authored-by: mary-georgiou-sonarsource <mary.georgiou@sonarsource.com> Co-authored-by: Tim Pohlmann <tim.pohlmann@sonarsource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7565
RSPEC PR: SonarSource/rspec#2481