SONARHTML-212 Create rule S6825: Focusable elements should not have "aria-hidden" attribute #285
Conversation
.../test/java/org/sonar/plugins/html/checks/accessibility/NoAriaHiddenOnFocusableCheckTest.java
Outdated
Show resolved
Hide resolved
|
One very minor suggestion, but otherwise LGTM. |
…accessibility/NoAriaHiddenOnFocusableCheckTest.java Co-authored-by: Eric Morand <156682586+ericmorand-sonarsource@users.noreply.github.com>
|
ilia-kebets-sonarsource
deleted the
SONARHTML-212-S6825-focusable-elements-no-aria-hidden-attribute
branch
| public static boolean isFocusableElement(TagNode element) { | ||
| String tabindex = element.getAttribute("tabindex"); | ||
| if (isInteractiveElement(element)) { | ||
| return tabindex == null || Double.parseDouble(tabindex) >= 0; | ||
| } | ||
| return tabindex != null && Double.parseDouble(tabindex) >= 0; | ||
| } |
There was a problem hiding this comment.
There is a false positive for <input type="hidden"/>, it should not be focusable.
https://sonarcloud.io/project/issues?impactSoftwareQualities=RELIABILITY&resolved=false&types=CODE_SMELL&id=jhipster-sample-application&open=AY3niTmAHmRkDeY1zyU2
There was a problem hiding this comment.
that's been fixed and will appear in the next release.
There was a problem hiding this comment.
The next release for VSCode v4.4.2 came out a few days ago but still appears to be an issue
There was a problem hiding this comment.
You can track its release in this card.
No description provided.