SONARPY-1866 Infer types of reassigned parameters even when they don't have type annotationst have type annotations #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-1866
branch
from
834de23 to
78d25eb
Compare
guillaume-dequenne
approved these changes
May 21, 2024
| @@ -377,7 +377,7 @@ def foo(param): | |||
|
|
|||
| var functionDef = (FunctionDef) root.statements().statements().get(0); | |||
| var lastExpressionStatement = (ExpressionStatement) functionDef.body().statements().get(functionDef.body().statements().size() -1); | |||
| Assertions.assertThat(lastExpressionStatement.expressions().get(0).typeV2().unwrappedType()).isEqualTo(PythonType.UNKNOWN); | |||
| Assertions.assertThat(lastExpressionStatement.expressions().get(0).typeV2().unwrappedType().name()).isEqualTo("str"); | |||
There was a problem hiding this comment.
Please compare to STR_TYPE directly instead of using name.
guillaume-dequenne
force-pushed
the
MMF-3796
branch
from
c814696 to
1738f0b
Compare
…t have type annotations
maksim-grebeniuk-sonarsource
force-pushed
the
SONARPY-1866
branch
from
78d25eb to
dfd6486
Compare
|
guillaume-dequenne
pushed a commit
that referenced
this pull request
May 21, 2024
…t have type annotations (#1809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.