SONARPY-394 Migrate FieldNameCheck to strongly typed AST #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pynicolas
force-pushed
the
fieldname
branch
from
1a59f54 to
80bcbd3
Compare
benzonico
changed the title
benzonico
requested changes
Sep 24, 2019
| import org.sonar.python.parser.PythonParser; | ||
| import org.sonar.python.tree.PythonTreeMaker; | ||
|
|
||
| public class SemanticTest { |
There was a problem hiding this comment.
This is factorization by inheritance, I would rather make this a utility class with a static method.
| } | ||
| }); | ||
| scopesByRootTree.values().stream() | ||
| .filter(scope -> scope.rootTree instanceof PyClassDefTree) |
There was a problem hiding this comment.
Why not use of .is(Tree.Kind.CLASSDEF) ?
| 'project:twisted-12.1.0/twisted/internet/task.py':[ | ||
| 63, | ||
| 64, | ||
| 112, |
There was a problem hiding this comment.
I don't understand why this issue is missing and not relevant anymore : this is an instance field and should be detected as such.
There was a problem hiding this comment.
And I figured it out : this self variable is instantiated via a class method. This is way out of scope of this sprint, so fine to accept this "loss" for now.
andrea-guarino-sonarsource
approved these changes
Sep 25, 2019
hashicorp-vault-sonar-prod bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
…es analysis (#360) GitOrigin-RevId: 673c28b6ac4ed5db19430d57872a5a02fec1b594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.