Skip to content

Avoid collecting unecessarily #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Avoid collecting unecessarily #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions python-checks/src/main/java/org/sonar/python/checks/AfterJumpStatementCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
*/
package org.sonar.python.checks;

import java.util.List;
import java.util.stream.Collectors;
import javax.annotation.Nullable;
import org.sonar.check.Rule;
import org.sonar.plugins.python.api.cfg.CfgBlock;
Expand Down Expand Up @@ -53,13 +51,12 @@ private static void checkCfg(@Nullable ControlFlowGraph cfg, SubscriptionContext
for (CfgBlock cfgBlock : cfg.blocks()) {
if (cfgBlock.predecessors().isEmpty() && !cfgBlock.equals(cfg.start()) && !cfgBlock.elements().isEmpty()) {
Tree firstElement = cfgBlock.elements().get(0);
List<Tree> jumpStatements = cfg.blocks().stream()
.filter(block -> cfgBlock.equals(block.syntacticSuccessor()))
.map(block -> block.elements().get(block.elements().size() - 1))
.collect(Collectors.toList());
Tree lastElement = cfgBlock.elements().get(cfgBlock.elements().size() - 1);
PreciseIssue issue = ctx.addIssue(firstElement.firstToken(), lastElement.lastToken(), "Delete this unreachable code or refactor the code to make it reachable.");
jumpStatements.forEach(jumpStatement -> issue.secondary(jumpStatement, null));
cfg.blocks().stream()
.filter(block -> cfgBlock.equals(block.syntacticSuccessor()))
.map(block -> block.elements().get(block.elements().size() - 1))
.forEach(jumpStatement -> issue.secondary(jumpStatement, null));
}
}
}
Expand Down