Skip to content

Conversation

benzonico
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please handle the 2 code smells reported by SQ. Could you also remove the exclusion on CPD while running ruling integration test?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to remove this commented code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted already

@benzonico benzonico force-pushed the test_and_fix_token_order branch from ca6177f to d18e643 Compare October 15, 2019 12:40
@benzonico benzonico force-pushed the test_and_fix_token_order branch from d18e643 to 8bcb268 Compare October 15, 2019 12:49
@andrea-guarino-sonarsource
Copy link
Contributor

LGTM!

@andrea-guarino-sonarsource andrea-guarino-sonarsource merged commit 387ea80 into master Oct 15, 2019
@andrea-guarino-sonarsource andrea-guarino-sonarsource deleted the test_and_fix_token_order branch October 15, 2019 13:08
hashicorp-vault-sonar-prod bot pushed a commit that referenced this pull request Jul 30, 2025
GitOrigin-RevId: ecf56167c6a7169e6f12eb26a6083d088b64313a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants