Sub groups #40
Sub groups #40
Conversation
… that has a SubstitutionGroupChildRule for it. Effectively, the DomXmlWriter was requiring that a substitution take place for the element. But according to the standard, it is acceptable for the original element to be used (if it is not abstract). Tests included.
…a) substitution option, and failing tests from Substitution Group fixes. In order to change DomXmlWriter to use the most derived substitution option, the substitutions are joined to the type lineage, which in order of derivation, before selecting the first substitution in the list. The failing tests were: - CircuitEditorTests.EditSaveCloseAndReopen - DiagramEditorTests.StatechartEditSaveCloseAndReopen
|
@Ron2 Here's the pull request we talked about. Let me know if you see changes that need to happen. |
|
Thank you very much, Jason. That was a lot of work on your part and the unit tests were well-written. I reviewed the changes and they look good but then when I ran the full test suite, another unit test failed -- ModifyChildDocumentExternally in TimelineEditorTests. I'm looking into what is going on there. |
|
Never mind about that unit test -- it fails in our current release and in our work-in-progress branch on my computer. I suspect it's somehow related to Windows 8.1 or my laptop somehow. Anyway, I merged in your changes. Thanks again! |
|
Thanks Ron, Glad to help. I've been really impressed with ATF, and have enjoyed Cheers, Jason On 6/9/2015 6:03 PM, Ron wrote:
|
I added the new tests to verify the change to a new unit test class, as that seemed to be the best place for them.