feat(Native): Support New Architecture (Bridge/Bridgeless) #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydkim
changed the title
floydkim
force-pushed
the
fabric-bridgeless
branch
from
1e44551 to
29e8e7d
Compare
…geless release) I found an issue in the Android RN 0.74.7 (New Architecture + Bridgeless) release build where the CodePush instance is newly created when reloading or updating downloads, causing the JS bundle file name to be reset to null. Since the CodePush instance is not newly created in Old Architecture and New Architecture Bridge mode, I modified it to be a singleton in Bridgeless mode as well.
floydkim
changed the title
floydkim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #13
Android
It uses the
reloadmethod ofReactDelegateintroduced in React Native 0.74.For versions below 0.74, it behaves the same as the previous implementation.
iOS
It uses
RCTTriggerReloadCommandListenersinstead of[_bridge reload](reference)Test Plan
Test environments
iOS / AndroidxDebug / ReleasexOld Architecture / New Architecture / New Architecture BridgelessTest Targets (the latest version of each minor version)