Skip to content

fix!: checkForUpdate function type doesn’t match runtime behavior #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix!: checkForUpdate function type doesn’t match runtime behavior #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions typings/react-native-code-push.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,9 @@ declare namespace CodePush {
/**
* Asks the CodePush service whether the configured app deployment has an update available.
*
* @param deploymentKey The deployment key to use to query the CodePush server for an update.
*
* @param handleBinaryVersionMismatchCallback An optional callback for handling target binary version mismatch
*/
function checkForUpdate(deploymentKey?: string, handleBinaryVersionMismatchCallback?: HandleBinaryVersionMismatchCallback): Promise<RemotePackage | null>;
function checkForUpdate(handleBinaryVersionMismatchCallback?: HandleBinaryVersionMismatchCallback): Promise<RemotePackage | null>;

/**
* Retrieves the metadata for an installed update (e.g. description, mandatory).
Expand Down