Skip to content

Conversation

11t518s
Copy link

@11t518s 11t518s commented Apr 13, 2025

정의된 command와 readme의 설명이 매칭되지 않는 부분이 있어서 이 부분만 바로잡는 pr 입니다.

라이브러리 잘 만들어주신 덕분에 잘 사용했습니다!

program.command('release')
    .description('Deploys a new CodePush update for a target binary app.\nAfter creating the CodePush bundle, it uploads the file and updates the ReleaseHistory information.\n`bundleUploader`, `getReleaseHistory`, and `setReleaseHistory` functions should be implemented in the config file.')
    .requiredOption('-b, --binary-version <string>', '(Required) The target binary version')
    .requiredOption('-v, --app-version <string>', '(Required) The app version to be released. It must be greater than the binary version.')
    .addOption(new Option('-p, --platform <type>', 'platform').choices(['ios', 'android']).default('ios'))
program.command('show-history')
    .description('Retrieves and prints the release history of a specific binary version.\n`getReleaseHistory` function should be implemented in the config file.')
    .requiredOption('-b, --binary-version <string>', '(Required) The target binary version for retrieving the release history.')
    .addOption(new Option('-p, --platform <type>', 'platform').choices(['ios', 'android']).default('ios'))

@floydkim floydkim self-requested a review April 13, 2025 13:03
Copy link
Member

@floydkim floydkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

기여해주셔서 감사드립니다!

@floydkim floydkim merged commit 5efbdde into Soomgo-Mobile:master Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants