Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optimize docs #7

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature/optimize docs #7

wants to merge 4 commits into from

Conversation

fieteboerner
Copy link
Collaborator

I've added some docs for some advanced actions and a rough term explanation.

Would be happy of you could skim over it.

I think we should merge this together with the next release because the docs are referring to shell args.

@fieteboerner fieteboerner requested a review from Sopamo July 31, 2022 10:51
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
#
# If running your commands in a simple `sh` is not enough you could
# launch your favorite shell as well to leverage more complex tasks
watch: zsh -c "source ~/.zshrc && nvm use && npm run watch"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be kinda nice to be able to configure the shell that should be used to start commands. Should be fairly easy, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, kind of. I think we have to configure the paths/names of the rc files for several popular shells.
But I think the via actions could get way slower because sourcing large/complex rc files is not for free. At the moment I would leave the trade-off to the user even it is more complicated to opt-in. But if we would source the files automatically we should have to design an opt-out.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I though of adding options to opt in to a specific shell on different levels, e.g. globally (in a new via.yaml), or on project level, or on service level

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Sopamo
Copy link
Owner

Sopamo commented Aug 1, 2022

Those are some great changes! I agree, that we should release when we merge this.

Co-authored-by: Paul Mohr <p.mohr@sopamo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants