Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and configured Dockerfile #118

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

anirudh-hegde
Copy link
Contributor

  • Docker encapsulates the application and dependencies.
  • Ability quickly set up the project by running the container, eliminating the need to install various libraries and tools manually.
  • Docker images can be versioned, which means, can run a specific container version suitable for my needs.

Steps:

cd SoundScape
docker build -t <image-name> .
docker run -u=$(id -u $USER):$(id -g $USER) -e DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix:rw -v $(pwd)/app:/app --rm <image-name> 

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @anirudh-hegde! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@anirudh-hegde
Copy link
Contributor Author

Tried to solve issue #32

@Soumya-Kushwaha
Copy link
Owner

@dinxsh plz have a look.

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be required to keep the code files ian new app dir? it would mess with the existing structure and the rest upcoming prs. if possible keep it in root dir itself
@anirudh-hegde

@anirudh-hegde
Copy link
Contributor Author

would it be required to keep the code files ian new app dir? it would mess with the existing structure and the rest upcoming prs. if possible keep it in root dir itself @anirudh-hegde

Ya will alter it.

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly remove the app folder too also fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants