Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Conversation

maksw2
Copy link

@maksw2 maksw2 commented Jul 16, 2024

Rotten to the core. There's no saving it -- we need to pull it out by the roots.
Wipe the slate clean. BURN IT DOWN! And from the ashes, a new (build system) will be born.

Senator Armstrong

@Sectonid Sectonid linked an issue Jul 17, 2024 that may be closed by this pull request
@Sectonid Sectonid added the enhancement New feature or request label Jul 17, 2024
@maksw2
Copy link
Author

maksw2 commented Jul 17, 2024

@Sectonidse how are the shaders built?

@Sectonid
Copy link
Collaborator

You can read the compiler here from line 125:
https://github.com/Sectonidse/SourceDEFUN/blob/master/materialsystem%2Fswarmshaders%2Fbuildshaders.bat

However, it doesn't build yet. It requies CMake project

I made the shader compilation a different job in Actions so fixing it would be much easier now

@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

so, to build shaders i just need to exec the script?

@Sectonid
Copy link
Collaborator

yes

@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

should i include that?

@maksw2 maksw2 changed the title Cmake CMake Jul 18, 2024
@Sectonid
Copy link
Collaborator

should i include that?

no, i want compiling shaders to be separate from compiling a game

@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

cool, so it's mostly finished. still neeed to fix some errors generated by cmake and it'll be done.

@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

review changes and tell me what you think.

@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

@Sectonidse oh shoot, i would need to merge it to master, not cmake. anyways, how are the changes?

Copy link
Collaborator

@Sectonid Sectonid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late response, i was experimenting with GMod's Lua scripting.

I'm gonna merge this, but i think that Git might revert some new changes that your pull request doesn't have.

@Sectonid Sectonid marked this pull request as ready for review July 18, 2024 14:43
@Sectonid Sectonid merged commit 8802cee into SourceDEFUN:cmake Jul 18, 2024
@maksw2
Copy link
Author

maksw2 commented Jul 18, 2024

github works on diffs, not the files. and since all i did is cmake it won't.

@maksw2
Copy link
Author

maksw2 commented Jul 19, 2024

it wasn't ready yet!

@Sectonid
Copy link
Collaborator

it wasn't ready yet!

I'm sorry, i realised that after merging. I didn't knew the button would make the pull request ready, i thought you prepared it. I'm giving you access to modify cmake branch directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate a solution with CMake or use WAF
2 participants