-
Notifications
You must be signed in to change notification settings - Fork 0
CMake #17
CMake #17
Conversation
Don't forget to make the system for it and finish the activities dictionary
update solution
No more code comments about modifications!
the shader compilation
@Sectonidse how are the shaders built? |
You can read the compiler here from line 125: However, it doesn't build yet. It requies CMake project I made the shader compilation a different job in Actions so fixing it would be much easier now |
so, to build shaders i just need to exec the script? |
yes |
should i include that? |
no, i want compiling shaders to be separate from compiling a game |
cool, so it's mostly finished. still neeed to fix some errors generated by cmake and it'll be done. |
review changes and tell me what you think. |
@Sectonidse oh shoot, i would need to merge it to master, not cmake. anyways, how are the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late response, i was experimenting with GMod's Lua scripting.
I'm gonna merge this, but i think that Git might revert some new changes that your pull request doesn't have.
github works on diffs, not the files. and since all i did is cmake it won't. |
it wasn't ready yet! |
I'm sorry, i realised that after merging. I didn't knew the button would make the pull request ready, i thought you prepared it. I'm giving you access to modify cmake branch directly. |
Rotten to the core. There's no saving it -- we need to pull it out by the roots.
Wipe the slate clean. BURN IT DOWN! And from the ashes, a new (build system) will be born.
Senator Armstrong