ffe-account-selector-react: Disregard formatting when searching for account numbers #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component expects preformatted input. This change is required to reproduce #6 locally.
Searches for account numbers no longer have to include spaces to match. For instance for the account number `1234 56 789101` you can now type `12345` and still get a match.
wkillerud
changed the title
kwltrs
pushed a commit
that referenced
this pull request
Mar 7, 2018
ffe-account-selector-react: Disregard formatting when searching for account numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
These changes make sure to apply the same string replace to both the query and the queried. This way we can be sure that formatting doesn't factor into the search.