Skip to content

Issue-168: Optional automatic retry on 5xx #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2017
Merged

Issue-168: Optional automatic retry on 5xx #169

merged 2 commits into from
Jul 10, 2017

Conversation

ewandennis
Copy link
Contributor

Addresses #168:

  • Added a retries option to control API call retry count
  • By default, no retries are attempted to protect existing tested code paths and compatibility
  • When enabled, each request will be retried until it returns non 5xx status or retries attempts are reached.

@avigoldman
Copy link
Contributor

avigoldman commented Jul 6, 2017 •
edited
Loading

Do you think its worth while to add a sample of using retries? Maybe in the message-events examples? LGTM though 👍

@ewandennis ewandennis merged commit 342ecf6 into master Jul 10, 2017
@ewandennis ewandennis deleted the issue-168 branch July 10, 2017 15:13
@ewandennis ewandennis mentioned this pull request Aug 11, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewandennis @avigoldman