Travis CI pass on PHP v7.3 and 7.4 #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 10, 2021 16:07
…parkpost into fix-php-cs-fixer
Merged
|
Closing this as #200 supersedes it, providing support for wider range of versions too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the previous Travis CI failures on these PHP versions, arising from outdated dependencies.
Updating these dependencies has the knock-on effect of Travis CI tests no longer being able to run on PHP v7.2 and older.
This is because the required version of support tooling (such as
phpunit) has no compatibility with older versions.FWIW getting a “pass” from
phpunitrequires (minor) changes to the test code definitions (particularly in the four areas of catching exceptions where these are expected in the test) and wholesale changes thephpunit.xml.distfile, achieved by./vendor/bin/phpunit --migrate-configurationPHP has fairly tight "supported version" windows anyway so I think it's reasonable to deprecate ancient, officially-unsupported versions and move forwards. The solution proposed here, is with a note in the README, referring users to older library releases if they need them.