Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 support #200

Merged
merged 9 commits into from
Mar 15, 2021
Merged

PHP 8 support #200

merged 9 commits into from
Mar 15, 2021

Conversation

andrew-nuwber
Copy link
Contributor

@andrew-nuwber andrew-nuwber commented Mar 12, 2021 •
edited
Loading

  • fixes for PHP 8
  • dev dependencies update
  • PHPUnit config fix
  • minimal PHP version 7.2

@tuck1s
Copy link

tuck1s commented Mar 12, 2021

This looks good to me, and could supersede my draft PR #199

@tuck1s tuck1s mentioned this pull request Mar 12, 2021
Closed
@tuck1s
Copy link

tuck1s commented Mar 12, 2021 •
edited
Loading

The removal of composer.lock seems to be a valid thing to do for libraries, according to: https://getcomposer.org/doc/02-libraries.md#lock-file

@tuck1s tuck1s mentioned this pull request Mar 12, 2021
Closed
@tuck1s tuck1s merged commit eeb6ba9 into SparkPost:master Mar 15, 2021
@tuck1s tuck1s mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-nuwber @tuck1s