Django backend #57
Django backend #57
Conversation
Add unit tests
Add html messaging tests
| @@ -0,0 +1,6 @@ | |||
| class UnSupportedContent(Exception): | |||
There was a problem hiding this comment.
let's make that a lower-case S - UnsupportedContent
|
There is some uncovered code - let's get that covered: https://coveralls.io/builds/3989636/source?filename=sparkpost%2Fdjango%2Femail_backend.py |
| @@ -62,3 +62,4 @@ venv/ | |||
|
|
|||
| # Mac OSX | |||
| .DS_Store | |||
| .idea | |||
There was a problem hiding this comment.
add newline at end of file
|
Need docs. Would be nice to see this added to both the README and the sphinx docs. Get those in with the code updates and I'll give it another review. |
Improve tests by reducing duplications
rajumsys
force-pushed
the
django-backend
branch
4 times, most recently
from
e00fed8 to
f7c8a6d
Compare
rajumsys
force-pushed
the
django-backend
branch
from
f7c8a6d to
e75916a
Compare
rajumsys
force-pushed
the
django-backend
branch
from
2f45196 to
e8e389a
Compare
@richleland Added docs. |
| @@ -79,6 +79,17 @@ Here at SparkPost, our messages are known as transmissions. Let's use the underl | |||
|
|
|||
| .. _transmissions API: https://www.sparkpost.com/api#/reference/transmissions | |||
|
|
|||
| Django Integration | |||
| ------------------ | |||
| SparkPost python library comes with an email backend for Django. So, all you need is to use this backend in Django and put the API Key. | |||
There was a problem hiding this comment.
Couple copy edits:
- "The" SparkPost python library...
- Delete the second sentence.
Net is this:
The SparkPost python library comes with an email backend for Django. Put the following configuration in your
settings.pyfile:
|
|
||
| Supported version | ||
| ----------------- | ||
| SparkPost will support all Django versions of Django that are within extended support period. Refer to `Django Supported_Version`_. |
There was a problem hiding this comment.
Copy edit:
SparkPost will support all versions of Django that are within the extended support period. Refer to...
rajumsys
force-pushed
the
django-backend
branch
from
5573036 to
eb590c5
Compare
This PR implements the minimum version of Django backend. Just a start, still lot of scope of improvements.