Allow String Attachments. Referencing SparkPost/wordpress-sparkpost#132 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajumsys
reviewed
Oct 27, 2017
mailer.http.class.php
Outdated
| { | ||
| return file_get_contents($path); | ||
| if ( file_exists( $data ) ) { |
There was a problem hiding this comment.
Thanks for the PR. Do you think is_file is more appropriate, in terms of how it sounds at least. Also please add a comment of explaining why we're doing it so next person understands it quickly.
There was a problem hiding this comment.
Should be good now 👍
Good call on is_file(). Didn't realize file_exists() would return true on directories.
There was a problem hiding this comment.
Thank you very much, I'll test it in next week and merge it.
There was a problem hiding this comment.
Sorry, I couldn't manage time to test it yet. Hoping to do it today/tomorrow.
|
Thanks @d4mation. Merged it. |
|
No problem, @rajumsys! |
maxharrisnet
pushed a commit
that referenced
this pull request
Sep 17, 2020
AC-1552 Migrate the sites/default/files directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Attachments that have been added using PHPMailer's
addStringAttachment()method to be sent properly via the HTTP API.An example can be seen in #132.