Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow String Attachments. Referencing SparkPost/wordpress-sparkpost#132 #133

Merged
merged 2 commits into from Oct 31, 2017

Conversation

@d4mation
Copy link
Contributor

d4mation commented Oct 27, 2017

This allows Attachments that have been added using PHPMailer's addStringAttachment() method to be sent properly via the HTTP API.

An example can be seen in #132.

{
return file_get_contents($path);
if ( file_exists( $data ) ) {

This comment has been minimized.

Copy link
@rajumsys

rajumsys Oct 27, 2017

Contributor

Thanks for the PR. Do you think is_file is more appropriate, in terms of how it sounds at least. Also please add a comment of explaining why we're doing it so next person understands it quickly.

This comment has been minimized.

Copy link
@d4mation

d4mation Oct 27, 2017

Author Contributor

Should be good now 👍

Good call on is_file(). Didn't realize file_exists() would return true on directories.

This comment has been minimized.

Copy link
@rajumsys

rajumsys Oct 28, 2017

Contributor

Thank you very much, I'll test it in next week and merge it.

This comment has been minimized.

Copy link
@rajumsys

rajumsys Oct 31, 2017

Contributor

Sorry, I couldn't manage time to test it yet. Hoping to do it today/tomorrow.

@rajumsys rajumsys merged commit 7f13ec0 into SparkPost:master Oct 31, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 40.576%
Details
@rajumsys

This comment has been minimized.

Copy link
Contributor

rajumsys commented Oct 31, 2017

Thanks @d4mation. Merged it.

@d4mation

This comment has been minimized.

Copy link
Contributor Author

d4mation commented Nov 1, 2017

No problem, @rajumsys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.