New command: sai cli convert #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage: sai cli convert [format] [input] [output] (options...) As the first supported format, added the TUM ASL/DSO/EuRoC format (as format = tum). Co-authored-by: Pekka Rantalankila <40019233+pekkaran@users.noreply.github.com>
oseiskar
force-pushed
the
sai-cli-convert
branch
from
01f83cd to
db0dd7e
Compare
pekkaran
reviewed
Jan 23, 2025
pekkaran
reviewed
Jan 23, 2025
pekkaran
reviewed
Jan 23, 2025
pekkaran
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
As the first supported format, added the TUM ASL/DSO/EuRoC format (as format = tum).
Another option would have been adding a
--format=tumlike parameter and common params like input and output, instead of making each format a subparser.However, this version gives complete freedom to each converter to add their own parameters, which is probably better as each input format is may have its own kinks that are not shared with other formats.