Skip to content

sai-cli diagnose: Remove --output_json option and change --output_html to positional argument #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

sai-cli diagnose: Remove --output_json option and change --output_html to positional argument #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions python/cli/diagnose/diagnose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@

def define_args(parser):
parser.add_argument("dataset_path", type=pathlib.Path, help="Path to dataset")
parser.add_argument("--output_html", type=pathlib.Path, help="Path to calibration report HTML output.")
parser.add_argument("--output_json", type=pathlib.Path, help="Path to JSON output.")
parser.add_argument("output_html", type=pathlib.Path, help="Path to calibration report HTML output.")
parser.add_argument("--zero", help="Rescale time to start from zero", action='store_true')
parser.add_argument("--skip", type=float, help="Skip N seconds from the start")
parser.add_argument("--max", type=float, help="Plot max N seconds from the start")
Expand All @@ -38,10 +37,6 @@ def generateReport(args):
'dataset_path': str(jsonlFile.parent)
}

if not args.output_html and not args.output_json:
print("Either --output_html or --output_json is required")
return

data = {
'accelerometer': {"v": [], "t": [], "td": []},
'gyroscope': {"v": [], "t": [], "td": []},
Expand Down Expand Up @@ -138,18 +133,10 @@ def addMeasurement(type, t, v):
diagnoseGNSS(data, output)
diagnoseCpu(data, output)

if args.output_json:
if os.path.dirname(args.output_json):
os.makedirs(os.path.dirname(args.output_json), exist_ok=True)
with open(args.output_json, "w") as f:
f.write(json.dumps(output, indent=4))
print("Generated JSON report data at:", args.output_json)

if args.output_html:
if os.path.dirname(args.output_html):
os.makedirs(os.path.dirname(args.output_html), exist_ok=True)
generateHtml(output, args.output_html)
print("Generated HTML report at:", args.output_html)
if os.path.dirname(args.output_html):
os.makedirs(os.path.dirname(args.output_html), exist_ok=True)
generateHtml(output, args.output_html)
print("Generated HTML report at:", args.output_html)

if __name__ == '__main__':
def parse_args():
Expand Down