feat(#206): Adds diff mode as annotation #207
Conversation
|
|
||
| if (isAnnotated(annotatedElement, HoverflyValidate.class)) { | ||
| final HoverflyValidate hoverflyValidate = annotatedElement.getAnnotation(HoverflyValidate.class); | ||
| hoverfly.assertThatNoDiffIsReported(hoverflyValidate.reset()); |
There was a problem hiding this comment.
If the assertion is failed, it will not proceed to shut down hoverfly. I think the assertion should be wrap in the following try... finally... block as well.
There was a problem hiding this comment.
AfterAll callback is always called, even in case of exception, so Hoverfly is closed there.
There was a problem hiding this comment.
My concern was that hoverfly.assertThatNoDiffIsReported in the AfterAll callback throws an AssertionError which is not in the try-finally block. So it stops the execution of the succeeding code.
There was a problem hiding this comment.
oh right sorry I just fixed my eyes in one part
junit5/src/main/java/io/specto/hoverfly/junit5/HoverflyExtension.java
Outdated
Show resolved
Hide resolved
|
@tommysitu I think everything is addressed now. |
|
@tommysitu Now :) |
|
Looks good! |
|
Any plan to release soon? I'd like to write about it on my next blog post. |
|
Nothing else is pending, we can do a release tomorrow. Just being curious, what's your next blog about? |
|
About hoverfly/service virtualization and java |
|
👍 Look forward to it! |
2 participants
No description provided.