Lazy iterator and other small improvements #325
Conversation
…eException artifacts.
…ake it lazy instead of reallocating the same list over and over again.
| isTruncated = result.getTruncated(); | ||
| marker = result.getNextMarker(); | ||
| remainingKeys -= result.getObjects().size(); | ||
| return new LazyObjectIterable(client, bucket, keyPrefix, nextMarker, maxKeys, 5); |
There was a problem hiding this comment.
5? dont you want this is be called DefaultRetries or something?
| private final int maxKeys; | ||
| private final int retryCount; | ||
|
|
||
| public LazyObjectIterable(final Ds3Client client, final String bucket, final String keyPrefix, final String nextMarker, final int maxKeys, final int retryCount) { |
There was a problem hiding this comment.
OR you can add a new constructor here that calls the other constructor with default retry value, this way this class contains all the behavior
There was a problem hiding this comment.
There was already the telescoping constructors in the helper functions, so I didn't want to move it over here as well.
There was a problem hiding this comment.
i just don't think that the helper class should hold the default for this calss
There was a problem hiding this comment.
The reason I think it should is that the helper function is currently where all that information exists. And rather than duplicating the telescoping constructors over into the iterator, it's all kept in one place.
| return; | ||
| } catch (final IOException e) { | ||
| if (retryAttempt >= retryCount) { | ||
| throw new RuntimeException("Failed to get the next set of objects from the getBucket request", e); |
There was a problem hiding this comment.
we need to add to this message that we reached the max number of retries
2 participants
No description provided.