Metadata dacl parsing bug #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…throwing an exception, because the Windoze record and restore doesn't work if you don't own the files it is trying to access or if you are not running as admin.
…nstead of throwing an exception, because the Windoze record and restore doesn't work if you don't own the files it is trying to access or if you are not running as admin.
…whether to log or not based on the type of exception contained in the event we emit.
If a file has no dacl entries, as may happen on a network-mounted file system, there wont be a principal entry. A principal is a combination of security provider, like NT AUTHORITY, and user name, e.g. NT AUTHORITY\Gracie. This code is looking for the user name -- the second half of the principal. With no principal, there is no second half of the principal.
Removing redundant error logging.
DenverM80
reviewed
Mar 2, 2017
| userDisplay = aclEntry.principal().getName().split("\\\\")[1]; | ||
| final String[] principalFields = aclEntry.principal().getName().split("\\\\"); | ||
|
|
||
| if (principalFields.length < 2) { |
There was a problem hiding this comment.
A comment here explaining this behavior would be useful to refer to in the future
DenverM80
approved these changes
Mar 2, 2017
Adding comments about getting the user name out of tyhe security principal in a file's DACL.
DenverM80
approved these changes
Mar 2, 2017
rpmoore
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://jira.spectralogic.com/browse/BPBROWSER-63
If a file has no Windoze dacl entries, as may happen on a network-mounted file system, there won't be a principal entry. A principal is a combination of
security provider, like NT AUTHORITY, and user name, e.g. NT AUTHORITY\Gracie. This code is looking for the user name -- the second half of the
principal. With no principal, there is no second half of the principal.