Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove callside @inline as this requires 1.8 #246

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

milankl
Copy link
Member

@milankl milankl commented Feb 7, 2023

fixes #81

@inline doesn't seem to be required for no allocations

julia> A = rand(OctaHEALPixGrid,16);
julia> B = rand(OctaHEALPixGrid,16);
julia> @btime RingGrids.eachgridpoint($A,$B)
  2.535 ns (0 allocations: 0 bytes)
Base.OneTo(1024)

@milankl milankl added the compatibility 👯 Changes necessary for compatibility between versions label Feb 7, 2023
@milankl milankl added this to the v0.5 milestone Feb 7, 2023
@milankl milankl merged commit b2e5fec into main Feb 7, 2023
@milankl milankl linked an issue Feb 7, 2023 that may be closed by this pull request
@milankl milankl deleted the mk/eachgridpoint branch February 7, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility 👯 Changes necessary for compatibility between versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Julia 1.7?
1 participant