-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "idw" to "kriging" in spatial_interpolation_kernel parameters #2708
Change "idw" to "kriging" in spatial_interpolation_kernel parameters #2708
Conversation
…ers preset because really depend on the geometry.
for more information, see https://pre-commit.ci
spatial_interpolation_method="idw", | ||
num_closest=3, | ||
spatial_interpolation_method="kriging", | ||
sigma_um=[20.0, 30.0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing p=1 to be constistent
spatial_interpolation_method="idw", | ||
num_closest=3, | ||
spatial_interpolation_method="kriging", | ||
sigma_um=[20.0, 30.0], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
This PR should also changes the detaulf kriging parameters to 20 (isotropic) and p=2. This gives better results for NP probes |
…d p=2 like kilosort4.
for more information, see https://pre-commit.ci
change "idw" to "krigging" in spatial_interpolation_kernel in parameters preset because really depend on the geometry.