Change "idw" to "kriging" in spatial_interpolation_kernel parameters #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers preset because really depend on the geometry.
for more information, see https://pre-commit.ci
yger
reviewed
Apr 11, 2024
| spatial_interpolation_method="idw", | ||
| num_closest=3, | ||
| spatial_interpolation_method="kriging", | ||
| sigma_um=[20.0, 30.0], |
There was a problem hiding this comment.
missing p=1 to be constistent
yger
reviewed
Apr 11, 2024
| spatial_interpolation_method="idw", | ||
| num_closest=3, | ||
| spatial_interpolation_method="kriging", | ||
| sigma_um=[20.0, 30.0], |
alejoe91
changed the title
|
This PR should also changes the detaulf kriging parameters to 20 (isotropic) and p=2. This gives better results for NP probes |
…d p=2 like kilosort4.
for more information, see https://pre-commit.ci
alejoe91
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change "idw" to "krigging" in spatial_interpolation_kernel in parameters preset because really depend on the geometry.