Patch imports in types.dart
#572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armiol, PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
=============================================
- Coverage 77.29% 63.08% -14.21%
- Complexity 2979 3248 +269
=============================================
Files 499 513 +14
Lines 11502 15657 +4155
Branches 668 1423 +755
=============================================
+ Hits 8891 9878 +987
- Misses 2383 5324 +2941
- Partials 228 455 +227 |
|
Codecov collapse is a mystery. |
armiol
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we allow the Gradle plugin to patch imports in any Dart file, not just in
.pb.dartones.In order to collect info about known types, we generate
types.dartfile in every package. Previously, our Gradle plugin did not resolve relative path imports in those files. Now it does. Thanks to that, we're able to use Dart Protobuf classes fromspine_clientinstead of generating them in place each time.Also,
protoDart.modulesis now final to prevent corrupting Gradle model withnulls.Also, a minor TODO in another Gradle tool is resolved (no issue attached).