Encapsulate routing setup #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * Allow non-public entity classes to declare columns. * Customize state routing during repo initialization.
... and use it for routing in tests.
Codecov Report
@@ Coverage Diff @@
## master #1065 +/- ##
============================================
+ Coverage 92.87% 92.89% +0.01%
- Complexity 3896 3933 +37
============================================
Files 539 542 +3
Lines 12591 12647 +56
Branches 653 662 +9
============================================
+ Hits 11694 11748 +54
- Misses 684 686 +2
Partials 213 213 |
... instead of factory method.
Also: * clear `boundedContext` link in a repo when closing. Primarily to make tests happy, but also to disallow activity in a context after closing.
... to make Mockito happy :(
alexander-yevsyukov
changed the title
…te-routing # Conflicts: # server/src/test/java/io/spine/server/BoundedContextTest.java
…te-routing # Conflicts: # server/src/test/java/io/spine/server/BoundedContextTest.java
alexander-yevsyukov
changed the title
|
@armiol, @dmdashenkov, PTAL. |
armiol
requested changes
May 17, 2019
server/src/main/java/io/spine/server/entity/rejection/StandardRejection.java
Show resolved
Hide resolved
| import static io.spine.util.Exceptions.newIllegalStateException; | ||
|
|
||
| /** | ||
| * Obtains the first field from multiple messages expecting each field |
There was a problem hiding this comment.
While I understand what you meant, this is only because we have discussed this behaviour previously.
This should be something like this:
Routes messages to a single target, which ID is the same as the first field of the routed message.
<p>It is expected that the types of the first field and the identifier are the same.
server/src/main/java/io/spine/server/route/StateUpdateRouting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/spine/server/entity/rejection/StandardRejection.java
Outdated
Show resolved
Hide resolved
|
@armiol, PTAL again. |
armiol
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way routing is customized. Previously, we relied on exposed
eventRouting()orcommandRouting()methods that gave access to customizing the routing schemas either in repository constructors or inonRegistered(). This worked, but unnecessarily exposed the routing schemas to user's repository classes.New way of routing customization exposes
setupEventRouting(),setupCommandRouting(), andsetupImportRouting()methods that are called during theRepository.init()(which is also introduced by this PR).The
init()is meant to be the place for general purpose customization which may be needed by a user's repository class.The
onRegistered()callback is left for compatibility reasons, and for the cases when additional configuration is needed after a repository is registered in the Bounded Context.Other notable changes:
BoundedContextgottoString()which returns the context name.Repositoryclears its reference to itsBoundedContext.StandardRejections.