Synchronize subscription registry #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
============================================
+ Coverage 92.24% 92.25% +0.01%
Complexity 4151 4151
============================================
Files 546 546
Lines 13143 13163 +20
Branches 745 743 -2
============================================
+ Hits 12124 12144 +20
- Misses 790 792 +2
+ Partials 229 227 -2 |
|
@armiol, PTAL. |
…ption-registry # Conflicts: # license-report.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles the issue appearing in the
MultitenantSubscriptionRegistry. Despite declaring all its methods assynchronized, the registry was not thread-safe.In this PR we:
MultitenantSubscriptionRegistrythread-safe via concurrent collections and thoughtful synchronization.The framework version is set to
1.0.1.