Improvements for testing utilities (part 1) #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not running it through normal deprecation cycle since these testing utilities are not used already. It's more practical to remove it sooner in favor of new Subject-based testing utilities.
This eliminates `GivenLifecycleFlags` class as a utility. There is newer API, which exposes `archivedFlag()` and `deletedFlag()` as `BooleanSubject`.
Codecov Report
@@ Coverage Diff @@
## master #1249 +/- ##
===========================================
+ Coverage 90.99% 91.09% +0.1%
+ Complexity 4828 4665 -163
===========================================
Files 631 596 -35
Lines 15129 14703 -426
Branches 846 831 -15
===========================================
- Hits 13766 13394 -372
+ Misses 1101 1049 -52
+ Partials 262 260 -2 |
alexander-yevsyukov
changed the title
alexander-yevsyukov
changed the title
armiol
requested changes
Mar 17, 2020
There was a problem hiding this comment.
@alexander-yevsyukov LGTM in general. Please see my comments and suggestions.
testutil-server/src/main/java/io/spine/testing/server/blackbox/BlackBoxBoundedContext.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ContextAwareTest.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/ContextAwareTest.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/SubscriptionFixture.java
Outdated
Show resolved
Hide resolved
testutil-server/src/main/java/io/spine/testing/server/blackbox/SubscriptionFixture.java
Outdated
Show resolved
Hide resolved
armiol
approved these changes
Mar 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR:
Verify-based API is removed. This includes bothclientandserverpackages.Remaining bits related to
VerifyAcknowledgementsis going to be removed in the following PR.ContextAwareTestabstract test suite base is introduced.Improvements in
BlackBoxBoundedContext:EventStoreso the user can arrange a test environment this way.eventBus()andcommandBus().subscribe(Topic)now returnsSubscriptionFixturewhich can assert both entity states and event messages viaIterableOfProtosSubject.Changes to
BlackBoxBoundedContextand removal of old Verify-based API are breaking. It's more or less safe to do since the number of users are small, and efforts for arranging full deprecating cycle will not pay off.