(set_once) in entities
#1268
Merged
(set_once) in entities
#1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1268 +/- ##
============================================
+ Coverage 91.06% 91.07% +0.01%
+ Complexity 4668 4667 -1
============================================
Files 597 597
Lines 14801 14801
Branches 843 842 -1
============================================
+ Hits 13478 13480 +2
+ Misses 1062 1061 -1
+ Partials 261 260 -1 |
|
@armiol, PTAL. |
armiol
approved these changes
Apr 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
(set_once)constraint in entities was ignored. Since this PR, we will check entity state changes and produceConstraintViolatedsystem event if an entity state change violates a(set_once)constraint.