Improve support of rejections thrown from the CommandBus filters
#1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to avoid the name clash with `io.spine.core.Acks`.
Also, delete a redundant test class.
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
============================================
- Coverage 91.05% 91.05% -0.01%
- Complexity 4714 4732 +18
============================================
Files 606 608 +2
Lines 15009 15063 +54
Branches 853 854 +1
============================================
+ Hits 13666 13715 +49
- Misses 1075 1081 +6
+ Partials 268 267 -1 |
|
@armiol PTAL. |
armiol
requested changes
Aug 28, 2020
| */ | ||
| @Internal | ||
| public final class Buses { | ||
| public final class AckFactory { |
| * {@linkplain Ack posting result} with either status otherwise | ||
| */ | ||
| Optional<Ack> accept(E envelope); | ||
| Optional<Ack> doFilter(E envelope); |
There was a problem hiding this comment.
Not sure why rename that.
The idea of having a method like doFilter() is to avoid the clash with filter() in the public API. We don't have filter() here.
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| // NO-OP. |
|
|
||
| @Override | ||
| public void onError(Throwable t) { | ||
| // NO-OP. |
There was a problem hiding this comment.
Same as above. Shouldn't we rethrow the exception?
| * An observer which processes the {@linkplain io.spine.base.ThrowableMessage rejections} | ||
| * thrown by the bus {@linkplain BusFilter filters}. | ||
| * | ||
| * <p>Is NO-OP at bus creation. Once an {@link EventBus} is |
There was a problem hiding this comment.
When the bus is first created, this observer does nothing. Once an {@link EventBus} is ...
|
@armiol PTAL again. |
armiol
approved these changes
Sep 1, 2020
This was referenced Sep 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses SpineEventEngine/web#6.
Currently, the
Ackreceived from a command filter can contain eitherOKstatus,Error, or rejectionEvent.While the first two cases are well-supported in the current implementation, the
rejectionfield is not really expected to be populated.Per vocal discussion, it was decided that receiving a rejection in a command filter is actually a valid use-case, and thus this PR tweaks the
coreto support such a case. The system context will post the corresponding system events when the command is rejected this way, and the provided rejection event will be posted to theEventBus.Other changes
BusFilterinterface is expanded with shortcut methods for the convenientAckcreation.testingCopy()and can thus be specified onBlackBoxContextcreation.AbstractCommandHandlerwill post the corresponding events when its handler method invocation leads to a rejection.The library version advances to
1.5.27.