Fix empty dispatching delivery #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armiol @alexander-yevsyukov PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
============================================
- Coverage 91.02% 91.01% -0.01%
- Complexity 4765 4771 +6
============================================
Files 614 614
Lines 15135 15137 +2
Branches 858 858
============================================
+ Hits 13776 13777 +1
Misses 1087 1087
- Partials 272 273 +1 |
alexander-yevsyukov
approved these changes
Jan 13, 2021
| /** | ||
| * Ignores temperature changes outside its own range. | ||
| */ | ||
| public final class SafeThermometer extends Aggregate<ThermometerId, Thermometer, Thermometer.Builder> { |
There was a problem hiding this comment.
Грядущими морозами навеяло? ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1352.
The root cause of the issue was using
hasProducedEventsmethod which actually is just checking that theProducedEventsmessage is set, but does not check if there are any events inside.