Skip to content

Conversation

armiol
Copy link
Contributor

@armiol armiol commented Oct 25, 2021

Previously, CatchUpProcess used a repository cache to ensure that each process instance was interacting with the matching ProjectionRepository. However, the caching was tied up to the ID of the catch-up process, which eventually led to missing hits — when the steps of the process were processed on different servers.

This changeset addresses the issue by using the projection type URL as a caching key, and moving the cache population to the initialization phase of the corresponding Bounded Context.

The library version is bumped to 1.7.7-SNAPSHOT.4.

@armiol armiol self-assigned this Oct 25, 2021
@armiol armiol requested a review from dmitrykuzmin October 25, 2021 17:20
@armiol
Copy link
Contributor Author

armiol commented Oct 25, 2021

@dmitrykuzmin PTAL.

Copy link
Contributor

@dmitrykuzmin dmitrykuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@armiol armiol changed the title Improve Catch-up Caching [1.x] Improve Catch-up Caching Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #1406 (abee9b3) into 1.x-dev (d335e13) will decrease coverage by 0.03%.
The diff coverage is 89.47%.

@@              Coverage Diff              @@
##             1.x-dev    #1406      +/-   ##
=============================================
- Coverage      91.02%   90.99%   -0.04%     
+ Complexity      4791     4788       -3     
=============================================
  Files            614      615       +1     
  Lines          15203    15197       -6     
  Branches         860      859       -1     
=============================================
- Hits           13839    13828      -11     
- Misses          1093     1100       +7     
+ Partials         271      269       -2     

@armiol armiol merged commit 896cf4b into 1.x-dev Oct 25, 2021
@armiol armiol deleted the catch-up-stabilization branch October 25, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants