CommandStore as a Repository #394
Conversation
…ository Conflicts: server/src/main/java/org/spine3/server/command/CommandStorage.java
Conflicts: server/src/main/java/org/spine3/server/entity/AbstractEntity.java
Also: * Removed `BoundedContext` ctor parameter required for `Repository` and made it where dependency on a `BoundedContext` is really needed. * Removed `CommandStorage` as an abstract class that needs to be implemented and created by a `StorageFactory`.
Also removed `@SPI` annotation from `CommandStore`, which is package-private can is not SPI because of this.
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
============================================
+ Coverage 92.86% 92.88% +0.01%
- Complexity 2352 2355 +3
============================================
Files 230 229 -1
Lines 7516 7532 +16
Branches 541 543 +2
============================================
+ Hits 6980 6996 +16
- Misses 411 414 +3
+ Partials 125 122 -3Continue to review full report at Codecov.
|
|
@armiol, PTAL. |
There was a problem hiding this comment.
@alexander-yevsyukov LGTM except for the Javadoc wording issues. Please take a look at those before merging.
| * @param status | ||
| * a command status to set in the record | ||
| * @param generatedCommandId | ||
| * a command ID to used because the passed command does not have own ID. |
There was a problem hiding this comment.
Should be ... to be used... or ... to use ....
| * a command status to set in the record | ||
| * @param generatedCommandId | ||
| * a command ID to used because the passed command does not have own ID. | ||
| * If the command has own ID this parameter is {@code null}. |
There was a problem hiding this comment.
Please insert a comma after has own ID.
| * But this ID does not belong to the command. | ||
| * | ||
| * <p>Therefore, commands without ID can be found by records | ||
| * where `command.context.command_id` field is empty. |
There was a problem hiding this comment.
Should we use {@code command.context.command_id} instead of backquotes?
|
|
||
| /** The repository completed the catch-up process. */ | ||
| ONLINE, | ||
| /** If {@code true} the projection will {@link #catchUp()} after initialization. */ |
There was a problem hiding this comment.
I would add an alternative text to this {@link #catchUp()}.
This PR implements
CommandStoreas aRepository.Breaking changes:
Repositorynow does not haveBoundedContextconstructor argument.AggregatePartRepository,ProcessManagerRepository, andProjectionRepositorystill have such a constructor argument.CommandStorecreates its storage with the help ofStorageFactoryfor creatingCommandStoreas a repository.StorageFactorydoes not produceCommandStorageany more.InMemoryCommandStorageclass was also removed.