Clarify the API of ...Endpoints
#933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflect what they actually do. Inline some of `AggregateRepository` methods to simplify and thus prepare it to `Inbox`.
…spatch-operations
|
@dmdashenkov PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
============================================
+ Coverage 93.03% 93.05% +0.02%
+ Complexity 3715 3711 -4
============================================
Files 508 508
Lines 12143 12139 -4
Branches 676 676
============================================
- Hits 11297 11296 -1
+ Misses 623 621 -2
+ Partials 223 222 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityMessageEndpointhad numerousdispatchNow,dispatchTo,deliverNowetc methods that serve different purposes, but are named in very similar manner.This changeset is devoted to renaming and/or removing these methods in accordance with their purpose.
Also, the internal structure of repositories, which communicate with endpoints is slightly modified.
This is the second PR in a chain of requests leading to
Inboxintroduction. In the following requests the hierarchy ofEntityMessageEndpointdescendants will be modified even further to work withInbox-provided routines.