Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting gists #294

Merged
merged 3 commits into from Jan 9, 2022
Merged

Fix getting gists #294

merged 3 commits into from Jan 9, 2022

Conversation

robrbecker
Copy link
Member

@robrbecker robrbecker commented Jan 7, 2022

Fixes #288
The type of the files when getting a gist isn't a list, it is a map. This is a breaking change. So anywhere you were accessing the files from a gist before, you'll need to update your code to expect a map.

Breaking change: In the Gist class, the old type of files was

List<GistFile>? files;

and the new type is

Map<String, GistFile>? files;

Breaking change: In the GistFile class, the name property is now filename

While I was in there I noticed there were a lot of files that don't generate the toJson method. It doesn't hurt to generate those so I updated all the places that weren't generating toJson.

@robrbecker robrbecker added the semver:major Breaking Public API Changes (removals, renames) label Jan 7, 2022
@robrbecker robrbecker merged commit 27929dd into master Jan 9, 2022
@robrbecker robrbecker deleted the fix_gists branch January 9, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major Breaking Public API Changes (removals, renames)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can't get gist
2 participants