Fix up unit tests & run them in CI #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a makefile - added ocktokit scenarios - fixed up git_test.dart - actually run tests in CI
robrbecker
added
semver:patch
|
FYI @CaseyHillers |
|
Released in version 9.5.1 https://github.com/SpinlockLabs/github.dart/releases/tag/9.5.1 |
This was referenced Oct 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out tests were not being run in github actions, and were a bit broken. So this PR gets tests fixed up and running in CI.
Using mockito to mock the network request calls which return a non-nullable generic type was proving challenging even when using custom shims, so a different approach of using the nock package to mock our network requests was used. This turns out to be really nice and also verifies the the request is right because the request must match the mocked request or it fails. This means all of the basic tests in git_tests that just verify that getJSON are called with the correct URL are at least as good as before (verifying the URL matched expected) plus they exercise the deserialization pieces of code.