Add pending handler to concat 128kb or more data #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
This was referenced Sep 26, 2025
|
Huge thanks for fixing this critical bug 🙇 |
SpringMT
added a commit
that referenced
this pull request
Sep 26, 2025
…128kb-or-more-data Add pending handler to concat 128kb or more data
SpringMT
added a commit
that referenced
this pull request
Sep 26, 2025
Merge pull request #114 from cosmo0920/add-pending-handler-to-concat-…
|
I just released https://rubygems.org/gems/zstd-ruby/versions/1.5.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, this gem is unintentionally having a 128kb cliff to compress with zstd compression.
This is not good for large amount of data handling software like Fluentd.
Between Fluentd and Fluent Bit, we're heavily relying on zstd frames that is marked as magic byte for zstd specification.
Currently, this magic bytes is broken when exceeding 128 KB cliff (2^17).
This condition is easily exceeding. Because when ingesting about 5000 lines or more which is 128kb or more size of data.
Closes #112