Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bellhop.disconnect() doesn't work #21

Closed
steph643 opened this issue Apr 15, 2019 · 1 comment
Closed

Bellhop.disconnect() doesn't work #21

steph643 opened this issue Apr 15, 2019 · 1 comment

Comments

@steph643
Copy link

If you disconnect and reconnect, you end up receiving each message twice.

This is due to the fact that Bellhop.disconnect() doesn't release the event listener. Indeed, addEventListener (see this line) and removeEventListener (see this line) are not called on the same function.
steph643 pushed a commit to sylque/Bellhop that referenced this issue Apr 15, 2019
@sylque
Fix for SpringRoll#21
be2fba7
@steph643 steph643 mentioned this issue Apr 15, 2019
Merged
steph643 pushed a commit to sylque/Bellhop that referenced this issue Apr 15, 2019
@sylque
Fix for SpringRoll#21
8131381
chipbell4 added a commit that referenced this issue Apr 15, 2019
@chipbell4
Merge pull request #22 from steph643/fix
275407b 
Fix for #21
@chipbell4
Copy link
Contributor

Okay, this should be resolved now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chipbell4 @steph643