Updating iframe setup to use a local copy of the game #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes builds self-contained and not reliant on springroll.io's status
chipbell4
requested review from
902seanryan,
aberkie and
corinnejean
as code owners
902seanryan
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some scripts to clone the demo game into the "right place" so that the SpringRoll.io site can now depend on its local copy. This arguably makes local dev a little easier, and also makes builds run smoother (my true modus operandi here).
Also, perhaps most importantly: I changed the iframe URL to include
index.html. I could fight with CDN settings for the rest of the day, but I'm pretty sure this will fix the issue most quickly and easily.Let me know if you have any concerns with the approach. If not, I'll replicate these changes against the new documentation site we're working on.